Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update x/tools for https://github.com/golang/go/issues/51629 #396

Merged
merged 2 commits into from
Jul 30, 2022
Merged

Update x/tools for https://github.com/golang/go/issues/51629 #396

merged 2 commits into from
Jul 30, 2022

Conversation

dstrelau
Copy link
Contributor

Hi! I believe this fixes #390.

@quasilyte
Copy link
Owner

Hmm. Any ideas on why CI build fails?

`go env GOPATH`/bin/golangci-lint run ./...
level=error msg="Running error: context loading failed: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: golang.org/x/tools@v0.1.12 requires\n\tgithub.com/yuin/goldmark@v1.4.13: missing go.sum entry; to add it:\n\tgo mod download github.com/yuin/goldmark\n"

cristaloleg
cristaloleg approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@quasilyte quasilyte merged commit e750a0e into quasilyte:master Jul 30, 2022
@andig
Copy link

andig commented Aug 9, 2022

@quasilyte could you cut a release with this change? I'd hope this would enable go-critic/ golangci-lint to upgrade accordingly?

@quasilyte
Copy link
Owner

@andig done.
I'll roll a new gocritic release with updated ruleguard the next day.
I would like to merge a couple of more PRs there that address several 1.18 related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruleguard fails with "Unexpected package creation during export data loading" error.
4 participants
@dstrelau @quasilyte @andig @cristaloleg